Guidance for downstream bash completion packaging after v4.6 packaging cleanup #10
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hi Ryan,
Thanks for the v4.6 release.
In commit
e5f62bbc412b6f1bb14c4139a1dbcb97c32b5c81("Packaging updates"), the sample2ping.bash_completionwas removed with note:Could you share preferred guidance for downstream packagers on bash completion going forward?
Context from Homebrew:
Errno::ENOENT: No such file or directory - 2ping.bash_completionQuestions:
Happy to follow whichever direction you recommend and align the Homebrew packaging accordingly.
Thanks!
Thanks for reaching out! I seem to remember the bash-completion script was tightly coupled an older major version of bash-completion and at one point I was asked not to ship it at all because it was version-dependent... but I'm not entirely confident of that.
I'll look into it further, but on your side, do you know of any comparable situations with other packages? To be clear, I'm not opposed to re-adding it upstream if it is still relevant.
yeah, we either use command to run the generations (the CLI frameworks usually have it) or just pull the upstream bundled completions to install.
It's possible I was lumping it in with the .service / .spec files (which definitely should be distro-specific). I've gone ahead and re-added it in 4.6.1.
Although not related to completions, it would also help Homebrew and other packagers if https://github.com/rfinnie/2ping/pull/9 was merged